Tainted canvas error fix #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when loading the remote images we might encounter the tainted canvas error, I added the cross origin policy to overcome this situation. note that the remote server need to send proper access control headers in order this to work which means the remote server should allow using their images publicly or you can write a proxy to send your headers which is not legally right.
|
It works, thank you! |
|
@santimacia I'm glad that I helped someone, this is my first open-source contribution. Even though this is a tiny fix I'm feeling achieved. |
|
any chance of this getting a merge? or do I have to improve anything with my code? |
|
I guess this repo is not maintained anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the CORS error which caused the tainted canvas error on the situations when used with remote images. I added the crossOrigin attribute to the image element. But the remote server still needs to send proper CORS headers in order for this to work.